Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Fix statique update #84

Merged
merged 1 commit into from
Jun 10, 2024
Merged

[API] Fix statique update #84

merged 1 commit into from
Jun 10, 2024

Conversation

jmaupetit
Copy link
Member

@jmaupetit jmaupetit commented Jun 10, 2024

Purpose

When updating a statique entry, statique is only updated if a new related model is created.

Proposal

  • allow to update each related model fields
  • test utils and endpoints

@jmaupetit jmaupetit force-pushed the fix-statique-update branch from 9807ca6 to ef2d2fa Compare June 10, 2024 18:23
@jmaupetit jmaupetit self-assigned this Jun 10, 2024
@jmaupetit jmaupetit added bug Something isn't working critical WIP labels Jun 10, 2024
src/api/qualicharge/models/static.py Outdated Show resolved Hide resolved
src/api/tests/schemas/test_utils.py Outdated Show resolved Hide resolved
@jmaupetit jmaupetit removed the WIP label Jun 10, 2024
@jmaupetit jmaupetit marked this pull request as ready for review June 10, 2024 20:07
And not only create new entries when unique fields change.
@jmaupetit jmaupetit force-pushed the fix-statique-update branch from 2ea6168 to b6f56eb Compare June 10, 2024 20:08
@jmaupetit jmaupetit merged commit df7684b into main Jun 10, 2024
9 checks passed
@jmaupetit jmaupetit deleted the fix-statique-update branch June 10, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant