Merge pull request #18 from MTrab:Minor-fixes-for-new-API

Minor syntax fix for API changes

pydanfossally/__init__.py

@@ -1,5 +1,6 @@
 """Module for handling Danfoss Ally API communication"""
 
+# pylint: disable=invalid-name
 from __future__ import annotations
 
 import logging
@@ -47,14 +48,15 @@ def getDeviceList(self) -> None:
             _LOGGER.error("No devices loaded, API connection error?!")
             return
 
-        if not "result" in devices:
+        if "result" not in devices:
             _LOGGER.error("Something went wrong loading devices!")
             return
 
         for device in devices["result"]:
             self.handleDeviceData(device)
 
     def handleDeviceData(self, device: dict):
+        """Handle the device data."""
         self.devices[device["id"]] = {}
         self.devices[device["id"]]["isThermostat"] = False
         self.devices[device["id"]]["name"] = device["name"].strip()
@@ -133,7 +135,8 @@ def handleDeviceData(self, device: dict):
                     self.devices[device["id"]]["valve_opening"] = status["value"]
                 elif status["code"] == "LoadRadiatorRoomMean":
                     self.devices[device["id"]]["load_room_mean"] = status["value"]
-                elif status["code"] == "ext_measured_rs":
+                elif status["code"] == "sensor_avg_temp":
+                    # elif status["code"] == "ext_measured_rs":
                     self.devices[device["id"]]["external_sensor_temperature"] = (
                         float(status["value"]) / 10
                     )
@@ -186,7 +189,7 @@ def getDevice(self, device_id: str) -> None:
         if device is None or not device:
             _LOGGER.error("No device loaded, API error?!")
             return
-        if not "result" in device:
+        if "result" not in device:
             _LOGGER.error("Something went wrong loading devices!")
             return
 

test.py

@@ -1,4 +1,5 @@
 """For testing the module."""
+
 from os import environ
 from pprint import pprint
 
@@ -12,4 +13,4 @@
 
 ally.getDeviceList()
 
-pprint(vars(ally))
+pprint(vars(ally))