Simplifies isolation mechanisms #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgondu
changed the title
miguelgondu
changed the title
RMichae1
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Are these MlFlow observer changes new? Why do they pop up under the problem registration refactor?
There was a problem hiding this comment.
They were actually supposed to take place in the observer refactoring, but we forgot.
pyproject.toml
Outdated
There was a problem hiding this comment.
+1 Seems like a reasonable exclusion list.
miguelgondu
added this to the 1.0.0 - New observer interface + several black boxes for proteins milestone
RMichae1
reviewed
Jul 30, 2024
src/poli/objective_factory.py
Outdated
| quiet=quiet, | ||
| **kwargs_for_factory, | ||
| ) | ||
| # if not force_isolation: |
There was a problem hiding this comment.
Is there a point in cleaning up this block? Or is this temporary?
RMichae1
reviewed
Jul 30, 2024
src/poli/objective_factory.py
Outdated
| # evaluation_budget=evaluation_budget, | ||
| # quiet=quiet, | ||
| # **kwargs_for_factory, | ||
| # ) |
RMichae1
reviewed
Jul 30, 2024
| # it might be because you forgot to register your problem | ||
| # factory and black box inside the __init__.py file of | ||
| # the objective_repository. Remember that you need to add | ||
| # them to AVAILABLE_PROBLEM_FACTORIES and AVAILABLE_BLACK_BOXES. |
RMichae1
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Where did this one go? Or do we not want the basic examples anymore?
RMichae1
reviewed
Jul 30, 2024
src/poli/core/registry.py
Outdated
There was a problem hiding this comment.
I haven't tested the logic of these changes (yet), I'm only acknowledging that I am aware of the changes to the registry.
RMichae1
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
register_problemand everything associated with it.(Closes #211 )