Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

255 implement set of dms experiment results as static optimization problems #300

Merged
merged 24 commits into from
Feb 10, 2025
Merged

255 implement set of dms experiment results as static optimization problems #300

merged 24 commits into from
Feb 10, 2025

Conversation

RMichae1
Copy link
Collaborator

@RMichae1 RMichae1 commented Feb 6, 2025

Added DMS experiments for GB1 and TrpB.

Implemented as static lookup against table of fitness.csv assets.

@RMichae1 RMichae1 linked an issue Feb 6, 2025 that may be closed by this pull request
Implement set of DMS experiment results as static optimization problems #255
Closed
@RMichae1
Copy link
Collaborator Author

RMichae1 commented Feb 6, 2025 •
edited
Loading

Currently testing broken, with:

Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/rcml/miniforge3/envs/poli__dms/lib/python3.10/site-packages/poli/objective_factory.py", line 165, in create problem = __create_problem_from_repository( File "/Users/rcml/miniforge3/envs/poli__dms/lib/python3.10/site-packages/poli/objective_factory.py", line 94, in __create_problem_from_repository raise ValueError( ValueError: Objective function 'dms_trpb' is not available in the repository.

Even though objectives have been registered.

@RMichae1 RMichae1 requested a review from miguelgondu February 6, 2025 15:04
@RMichae1
Copy link
Collaborator Author

RMichae1 commented Feb 6, 2025

Test functions passing now.

@RMichae1 RMichae1 marked this pull request as ready for review February 6, 2025 15:19
miguelgondu
miguelgondu reviewed Feb 10, 2025
View reviewed changes
src/poli/objective_repository/dms_gb1/register.py Outdated

Raises:
-------
...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove this, I assume.

miguelgondu
miguelgondu reviewed Feb 10, 2025
View reviewed changes
src/poli/objective_repository/dms_trpb/isolated_function.py Outdated
for x_i in x:
# Assuming x_i is an array of strings
if len(x_i) != 4:
raise ValueError("Inputs of L=4 expected!")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a little bit more information in this error (e.g. current length len(x_i) and position i)?

miguelgondu
miguelgondu reviewed Feb 10, 2025
View reviewed changes
src/poli/objective_repository/dms_trpb/register.py Outdated

Raises:
-------
...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, you could remove this I imagine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

miguelgondu
miguelgondu approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@miguelgondu miguelgondu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, but otherwise looks good!

@RMichae1
Copy link
Collaborator Author

Removed empty docstring portions. Added more context to ValueErrors on incorrect inputs.

@RMichae1 RMichae1 merged commit 31eac5b into dev Feb 10, 2025
8 checks passed
@RMichae1 RMichae1 deleted the 255-implement-set-of-dms-experiment-results-as-static-optimization-problems branch February 10, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgondu miguelgondu miguelgondu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement set of DMS experiment results as static optimization problems
2 participants
@RMichae1 @miguelgondu