Allow listing security descriptor for any distinguished name #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey mate, thanks for the contribution! Indeed that's a problem I knew about, but I didn't know how to solve it properly without breaking other features. Let me take a look at what you did and test it a little bit. =) |
|
It seems to be working well in my lab, so I'm going to merge it. Good job and thanks again! =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, it is not possible to list security descriptors for certain objects, e.g. Active Directory DNS records. The reason for this is that objects like DNS records do not belong to a different root DN rather than the default root DN that is used in the query.
I fixed this by keeping the query as-is for SAM account names, and changing it for DNs such that the entered DN is the search root and the scope is
ldap.ScopeBaseObjectso only the exact object that corresponds to the DN is returned.