Adding support for google in pl_client.run #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abubakarsohail
requested changes
Jan 21, 2025
| @@ -72,6 +76,12 @@ | |||
| "stream_function": None, | |||
| }, | |||
| }, | |||
| "google": { | |||
There was a problem hiding this comment.
@raymond-chii why no completion support?
There was a problem hiding this comment.
@raymond-chii can you add google generativeai as a dev dependency as well?
| @@ -173,7 +173,9 @@ def _run_internal( | |||
| group_id, | |||
| pl_run_span_id, | |||
| metadata=metadata, | |||
| request_response=response.model_dump(), | |||
There was a problem hiding this comment.
Can we figure out a way to keep this as it is but call model_dump from the corresponding LLM providers functions that do support it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Google Gemini Support
Added support for Google's Gemini AI model to PromptLayer's
.run()method, allowing users to track and manage Gemini prompts through our prompt registry.Requires
google-generativeaipackage to be installed.