-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NRTM](GH-3088) Add colors and styles from ModernUI for official controls #3561
base: develop
Are you sure you want to change the base?
Conversation
@punker76 Could you confirm this is going the direction you were thinking about? |
93eac9d
to
2ab21cd
Compare
<ColumnDefinition Width="*" /> | ||
<ColumnDefinition Width="Auto" /> | ||
</Grid.ColumnDefinitions> | ||
<!-- TODO: MUI - Replace or implement this control --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@punker76 I can either use a metro circle button here or import this ModernButton
from MUI, any preference?
<Setter Property="Template"> | ||
<Setter.Value> | ||
<ControlTemplate TargetType="ProgressBar"> | ||
<!-- TODO: MUI - Import controls or find replacement --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
This comment is not directly related to this PR but adding even more resources made me wonder if I don't prefer to have the theme after and also for font size instead of @punker76 WDYT? |
Hi Guys, BTW is it possible to provide a few different ResourceDictionarys where always just one of them will be used in App.xaml merged Dictionary? So one for Metro-Style, one for Win10-Style, one for MUI-Style and so on? I know that this can be manually done, but it would be cool to have it. Happy coding |
3b8a0c6
to
9c0547c
Compare
I think so. My first 2 points after first review
|
@punker76 When creating |
@Evangelink /cc @punker76 Here is my suggetion with two examples https://github.com/timunie/MahApps.Metro/tree/DefaultResourceDictionarys
Happy coding |
9a8bd89
to
a9d2038
Compare
c1ffaf9
to
b1bf70f
Compare
f174def
to
55f365a
Compare
- Styles/MUI/Controls.xaml contains all styles for MUI - Styles/Controls.MUI.xaml sets all MUI styles to controls
Describe the changes you have made to improve this project
Provides colors, brushes and styles for the official controls implemented in ModernUI.
Buttons:
Checkboxes:
Radiobuttons:
Closed Issues
Fix #3088