Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing message field to be null to match SLF4J behavior #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quidryan
Copy link

(not really documented in Slf4j)

Quick stab at fixing #11. Comments welcome.

@Mahoney
Copy link
Owner

Mahoney commented Apr 19, 2016

Hi,

Thanks for this.

I was trying to follow a philosophy of never storing or exposing null, so always using Optional where a value could be absent, so this fix would break that pattern.

On the other hand this fix is backwards compatible, whereas changing getMessage() on LoggingEvent to return Optional would be a breaking change (though hopefully not a terribly arduous one if people are comparing events using the static helper constructors).

I'll think about what to do; possibly apply this change as a bug fix release to the 1.2 branch and make the breaking change in a 2.0 release.

@nicktindall
Copy link

+1

@neeme-praks-sympower
Copy link

Any hope of getting this merged and getting a new release of slf4j-test out?

@valfirst
Copy link

Please check out https://github.com/valfirst/slf4j-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants