Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version #2485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fenil2024
Copy link

update version

As this repository hosts multiple packages, please ensure the PR title starts with the name of the package that it relates to using square brackets (e.g. [flutter_local_notifications]). Should the PR more than one package than please prefix the title of the PR with [various] The contribution guidelines can be found at https://github.com/MaikuB/flutter_local_notifications/blob/master/CONTRIBUTING.md. Please review this as it contains details on what to follow when submitting a PR.

update version
@Levi-Lesches
Copy link
Contributor

Hey @fenil2024, a few notes:

Notes

  • you've changed compileOptions.XXXCompatibility to kotlinOptions.jvmTarget -- seems like we should be using both instead of just one. See https://github.com/flutter/flutter/pull/147326/files
  • Seems kotlinOptions.jvmTarget does not need .toString(), see the PR above

Breaking changes

  • bumped the compileSdk and targetSdkVersion from 34 -> 35
  • bumped the AGP version from 7.3.1 -> 8.7.0
  • bumped the Kotlin version from 1.7.20 -> 2.1.0
  • bumped the distributionUrl to use 7.4 to 8.9
  • commented out the jetifier.ignorelist and android.enableR8

Aside from not being documented, these breaking changes will affect our users, who are currently compiling with the "old" options. Do you need to make these breaking changes? Are you unable to compile without them? If so, please list what device/OS you're trying to compile and what errors you're getting. If not, let's leave them as they are.

It would probably be better to remove everything but the new kotlinOptions.jvmTarget, and I'll add that section to the new Android setup guide when I get a chance.

@Levi-Lesches
Copy link
Contributor

Possibly replaced by #2482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants