Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some conversion related fixes #4599

Merged
merged 8 commits into from
Dec 3, 2024
Merged

Some conversion related fixes #4599

merged 8 commits into from
Dec 3, 2024

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Nov 18, 2024

Description

This fixes a few small conversion related issues and adds tests for them:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 18, 2024

Benchmark Results

SHA: 3c9984ef48ef8064f78125a2fcee919bcebbf091

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@ffreyer ffreyer marked this pull request as ready for review November 19, 2024 15:38
@ffreyer
Copy link
Collaborator Author

ffreyer commented Dec 3, 2024

Also fixes #4641 (also a NaN rotation issue)

@ffreyer ffreyer merged commit 23ee755 into master Dec 3, 2024
22 checks passed
@ffreyer ffreyer deleted the ff/conversions branch December 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
3 participants