Remove miq-unicode.rb

[djberg96]

Remove miq-unicode.rb from gems-pending as part of the cleanup effort.

The main user of this was manageiq-smartstate, and that was reimplemented (using refinements) at ManageIQ/manageiq-smartstate#149. The other callers were virtfs-xxx repos, and those were archived.

[Fryguy]

I see a caller in https://github.com/ManageIQ/manageiq-smartstate/blob/23a23fec3db89859e280d9cc449946605543b2e6/lib/metadata/util/win32/Win32Accounts.rb#L627-L645, but there's no require of miq_unicode in that file. That method does not have any test coverage.

Also

• https://github.com/ManageIQ/manageiq-smartstate/blob/23a23fec3db89859e280d9cc449946605543b2e6/lib/disk/modules/MSVSDiffDisk.rb#L78
• https://github.com/ManageIQ/manageiq-smartstate/blob/23a23fec3db89859e280d9cc449946605543b2e6/lib/metadata/VmConfig/cfgConfig.rb#L8

[Fryguy]

Also seeing references in this repo directly:

• manageiq-gems-pending/lib/gems/pending/util/win32/miq-powershell.rb

  Line 6 in c2adf1f

  require 'util/miq-unicode'

  +

  manageiq-gems-pending/lib/gems/pending/util/win32/miq-powershell.rb

  Line 97 in c2adf1f

  encoded_command = MIQEncode.encode(script.AsciiToUtf8.Utf8ToUnicode, false)

[djberg96]

Ah, dammit, missed those. Will update.

[Fryguy]

For the one in this repo, it seems like only a single refernce, so I'd be ok with inlining the conversion

[djberg96]

@Fryguy ok, updated the inline one. I'll take a look at the smartstate code now.

[miq-bot]

Checked commit https://github.com/djberg96/manageiq-gems-pending/commit/b9c1f342570c66cfdc1cd74203f16e9f417ccea0 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

[djberg96]

I see a caller in https://github.com/ManageIQ/manageiq-smartstate/blob/23a23fec3db89859e280d9cc449946605543b2e6/lib/metadata/util/win32/Win32Accounts.rb#L627-L645, but there's no require of miq_unicode in that file.

It's picked up via disk/modules/MSCommon.rb

Same goes for MSVSDiffDisk.rb.

[djberg96]

https://github.com/ManageIQ/manageiq-smartstate/blob/23a23fec3db89859e280d9cc449946605543b2e6/lib/metadata/VmConfig/cfgConfig.rb#L8

Hah, well, how was this working before? I'll add it.

[djberg96]

@Fryguy ManageIQ/manageiq-smartstate#152