introduce all_attribute_names #23324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jrafanie
reviewed
Feb 4, 2025
1 task
jrafanie
reviewed
Feb 4, 2025
| def all_attribute_names | ||
| attribute_names | (try(:attribute_aliases)&.keys || []) | ||
| end | ||
|
|
||
| # @return Array[String] attribute names that can be advertised in the api and reporting | ||
| # Other attributes are accessible, they are just no longer in our public api (or never were) |
There was a problem hiding this comment.
What does this sentence mean? Can you provide an example?
There was a problem hiding this comment.
The original text says "non-hidden attributes"
There was a problem hiding this comment.
ok, let's merge it and if you think of a better way to describe it, we can edit it later. I don't have a better suggestion.
Fryguy
approved these changes
Feb 4, 2025
jrafanie
approved these changes
Feb 4, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
attribute_aliasvalues do not show up inattribute_names, so they are not discoverable.After
all_attribute_namesshow attributes and aliases and can be used for api and automate methods.See Also