Mesh can be scaled #121
Merged
Mesh can be scaled #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I should respect the SRT transform order, what do you think @alice-i-cecile ? I don't know how bevy does it though, I'd rather use the same order |
|
Yep, we should match Bevy. IIRC that's SRT. See bevyengine/bevy#1755 |
ManevilleF
added
enhancement
|
Done ! Looks good imo |
ManevilleF
commented
Oct 26, 2023
alice-i-cecile
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
PlaneMeshBuilder::with_scaleoption to scale generated meshColumnMeshBuilder::with_scaleoption to scale generated meshThe scale factor is applied before the rotation and offset, and I don't know if the API is clear enough or if it's the right way to do it.
Maybe it should be called
local_scale?