Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds OutlineMeshBuilder. #151

Closed
wants to merge 1 commit into from
Closed

Conversation

targrub
Copy link

@targrub targrub commented Feb 23, 2024

A quick-and-dirty implementation of mesh building for outlines around hexes. Probably visibly good only with ColorMaterials.

Probably visibly good only with `ColorMaterial`s.
@ManevilleF ManevilleF mentioned this pull request Feb 27, 2024
3 tasks
@ManevilleF
Copy link
Owner

Thanks for submitting this PR, this is a very interesting approach but I'm not a fan of using two HexLayouts with positive scale (here a hardcoded 1.1 scale factor) or having a separate builder.

I took some time to make a more generic approach, #152, through mesh insetting. Could you review it and try it out ? See if it can handle your outline use case ?

@targrub targrub closed this Mar 5, 2024
@targrub targrub deleted the outlines branch March 5, 2024 20:26
ManevilleF added a commit that referenced this pull request Mar 6, 2024
> Supercedes #151 
> Fixes #150

# Work done

- [x] Overhaul of primitive shape generation (Quads and hexagons), added
a mesh `utils` module with the primitive faces
- [x] Added face inset options to both builders
- [x] Overhaul of how Column mesh builder handles the caps options  

<img width="1077" alt="Screenshot 2024-02-28 at 11 29 14"
src="https://github.com/ManevilleF/hexx/assets/26703856/7656c497-438c-4e61-9398-ff2198997bda">

> Insetting hexagons and quads in mesh example

<img width="720" alt="Screenshot 2024-02-28 at 11 49 16"
src="https://github.com/ManevilleF/hexx/assets/26703856/7002e4c6-ebb7-41f2-85bc-ab2e0eb9f4c5">

> Example of insetting used in hex grid example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants