-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HeightMap mesh builder #170
Conversation
c899e9e
to
01c40c7
Compare
01c40c7
to
4a53a39
Compare
eba5db0
to
39f8bd8
Compare
ca7b932
to
cbb4d35
Compare
This is excellent! I'm unable to try it on my game as a whole until I'm fully updated to 0.15, but I was able to test it on a subset of my terrain generation and it's working quite well! I have a few thoughts and questions, but none of them are blocking.
Thanks for working on this feature, it's going to simplify a good chunk of my codebase! |
I'll see what I can do to improve this
I guess I could accept a
Could you give me an example on how that would look like API wise ? A side could be identified by a coordinate and a direction |
Yeah, no need to do something that would not allow for holes. I just use Hexx's storage types all over my project and it would remove a tiny bit of boilerplate if I could use them with
Perhaps mirroring pub const fn with_hex_cap_options(mut self, options: HashMap<Hex, Option<FaceOptions>>) -> Self
pub const fn with_hex_side_options(mut self, options: HashMap<Hex, Option<FaceOptions>>) -> Self
pub const fn with_hex_multi_sides_options(mut self, options: HashMap<Hex, [Option<FaceOptions>;6]>) -> Self Any hexes that have not had their |
@rsrasmu2 Investigating a bit and I noticed that the storages need to be upgraded to match hashmap behavior, which is a bit more work than I intend for this PR. I'm going to merge the PR as it is standing, and we can iterate on those suggestions before the release. Could you convert your comments/suggestions to an issue ? |
Adds a new
HeightMapMeshBuilder
with its associatedheightmap_builder
example