Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Mangos.Extractor to support WoTLK and Cata. Credit to Brotalnia. #52

Closed
wants to merge 1 commit into from

Conversation

Daribon
Copy link
Contributor

@Daribon Daribon commented Jun 25, 2021

This adds support to WoTLK and Cataclysm to Mangos.Extractor. This means that the extractor supports all versions between 0.5.3 alpha to 4.3.4 cataclysm after it is applied.

Credit goes out to Brotalnia for most of the code in this commit. Brotalnia gave me permission to publish his code. I just updated the code to match the formatting and coding style of the latest revision, since it was based on an older revision.

The patch also changes the following:

  • Updatefields output has been changed from C# to C++. Since the latter is widely more used in WoW emulation.
  • Removed patch and build from filename output, because it already includes it within the output text file.
  • Removed auto generated time and date from output text file, since its irrelevant.
  • Updatefield extractor is now an universal extractor for all versions with updatefield names in .exe. It will not run on any MoP patch or above, because the client stopped having updatefield names visible in MoP+.
  • Updated the extractors for opcodes, SpellFailedReasons and ChatTypes.

As for the first lines in the commit with no changes, I think someone prior to this commit mixed up windows and unix line endings. I tried to filter it out as best as I could on commit.


This change is Reviewable

@Romfos
Copy link
Contributor

Romfos commented Jun 26, 2021

Hi,

Now we support only WoW 1.12.1. Do we need it?

@Meltie2013
Copy link
Collaborator

@Romfos Would be nice to have incase we upgrade to another version with this source.

@billy1arm
Copy link
Contributor

billy1arm commented Jul 4, 2021

Hi,

Now we support only WoW 1.12.1. Do we need it?

Like main mangos, the Unified Extractor supports all versions of the core.

@billy1arm
Copy link
Contributor

@Daribon There are a couple of issues which need resolving:
https://www.codefactor.io/repository/github/mangosserver/mangossharp/pull/52

@SaxxonPike
Copy link

This is pretty cool. I see that C# output was removed for C++. Why not make it possible to do either one by user choice?

@billy1arm billy1arm added the enhancement New feature or request label Jan 24, 2023
@billy1arm
Copy link
Contributor

Closing this is changes made and included in PR#71:
#71

@billy1arm billy1arm closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants