-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gif timeserie #102
base: main
Are you sure you want to change the base?
Gif timeserie #102
Conversation
Moved animation test from service_wms to core. Added configuration for delay and animation in timedimension.
lib/core.c
Outdated
basemap = mapcache_assemble_maps(ctx, req_map->maps, req_map->nmaps, req_map->resample_mode); | ||
if(req_map->maps[0]->tileset->timedimension && | ||
req_map->maps[0]->tileset->timedimension->assembly_type == MAPCACHE_TIMEDIMENSION_ASSEMBLY_ANIMATE) | ||
basemap = mapcache_assemble_animated_maps(ctx, req_map->maps, req_map->nmaps, req_map->resample_mode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't pollute the core_get_map function with this switch, instead branch off to the specific assembly method inside mapcache_assemble_maps()
I've modified the I am also wondering, to remove When you say I could put the quantize functions in another file, would making a file like quantize.c and putting the quantizes functions in there and then including it where needed works? Thanks for the comments |
Note: We will simply modify other image writers to support more then one image. If more than one images are passed png and jpeg will fail and gif will animate them, |
Pull request related to http://www.mapserver.org/development/rfc/ms-rfc-111.html
This pull request adds a new format to MapCache, Gif. It also has a new write_frames function to encode an animated image.
It includes new attributes for the time dimension, animate and delay.
The check to see if we need to animate is in mapcache_core_get_map. It checks the assembly_type of the Tileset.