use v9.3 #42
Draft
use v9.3 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braktar
force-pushed
the
upgrade_ortools_version
branch
from
be59819 to
381b0e9
Compare
braktar
force-pushed
the
upgrade_ortools_version
branch
2 times, most recently
from
6494075 to
78d8a94
Compare
braktar
force-pushed
the
upgrade_ortools_version
branch
4 times, most recently
from
400def5 to
965a0c6
Compare
senhalil
reviewed
May 18, 2022
braktar
force-pushed
the
upgrade_ortools_version
branch
from
965a0c6 to
a9618e1
Compare
|
By the way, I think it would be better if you keep "use v9.0" commit untouched and make the modifications necessary (to switch to v9.3) in a separate commit on top of it -- because that is the history and we can easily see the diffs. I think you can just rebase the current "use v9.3" on top of the original "use v9.0" and it will be 👌 |
braktar
force-pushed
the
upgrade_ortools_version
branch
5 times, most recently
from
9d2d915 to
ca45ff5
Compare
braktar
force-pushed
the
upgrade_ortools_version
branch
from
93ec0f5 to
4bd4d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for almost all cases except for test
test_duration_adjusted_by_presence_of_restfor which ortools find a better solution by beginning the route at time 4 without purpose. Still need to investigate on it