Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add maxFilename limit for outputConfiguration #889

Merged
merged 7 commits into from
Feb 4, 2024

Conversation

Malinskiy
Copy link
Member

@Malinskiy Malinskiy commented Feb 3, 2024

Before:
maxPath limits the overall output file path length
After:
Fine-grained control over max filename and max file path

Reason for change:
Most modern filesystems (ext3, ext4, NTFS, APFS, etc) have max file name of 255 and very large or missing limits for max file path.

…nd max file name

Most modern filesystems have max file name of 255 and very large or missing limits for max file path
@Malinskiy Malinskiy requested a review from matzuk February 3, 2024 15:55
@Malinskiy Malinskiy changed the title fix(core): output configuration should have separated max file path a… fix(core): add maxFilename limit for outputConfiguration Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (d95eeff) 59.27% compared to head (6faa9c5) 59.24%.

Files Patch % Lines
...in/kotlin/com/malinskiy/marathon/io/FileManager.kt 57.14% 16 Missing and 8 partials ⚠️
...c/main/kotlin/com/malinskiy/marathon/di/Modules.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #889      +/-   ##
=============================================
- Coverage      59.27%   59.24%   -0.03%     
- Complexity       799      802       +3     
=============================================
  Files            214      214              
  Lines           4454     4468      +14     
  Branches         711      717       +6     
=============================================
+ Hits            2640     2647       +7     
  Misses          1481     1481              
- Partials         333      340       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Malinskiy Malinskiy merged commit 6c68772 into develop Feb 4, 2024
10 of 11 checks passed
@Malinskiy Malinskiy deleted the feature/imporove-max-filename-behaviour branch February 4, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants