Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): use marathon's time source for test timestamps #969

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix(ios): use marathon's time source for test timestamps #969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5809cf3
fix(ios): use marathon's time source for test timestamps
Malinskiy Aug 23, 2024
ed34189
fix(ios): add comment
Malinskiy Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...e/src/main/kotlin/com/malinskiy/marathon/apple/listener/AccumulatingTestResultListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,11 @@ abstract class AccumulatingTestResultListener(private val expectedTestCount: Int
testEnded(test, startTime, endTime)
}

/**
* Even though apple provides the timestamps for tests, there is no expectation of these being in sync with local time
*/
private fun testEnded(test: Test, startTime: Long, endTime: Long) {
runResult.testEnded(test = test, testMetrics = emptyMap(), endTime = endTime)
runResult.testEnded(test = test, testMetrics = emptyMap())
}

override suspend fun testRunFailed(errorMessage: String, reason: DeviceFailureReason) {
Expand Down
Loading