Fixed the issue in #114 (#116)

- Updated a test to catch this issue - Updated the WebsocketClient.cs accordingly
Marfusios · Oct 13, 2022 · 0fbe49e · 0fbe49e
1 parent ab841fd
commit 0fbe49e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/Websocket.Client/WebsocketClient.cs b/src/Websocket.Client/WebsocketClient.cs
@@ -191,9 +191,13 @@ public void Dispose()
                 Logger.Error(e, L($"Failed to dispose client, error: {e.Message}"));
             }
 
+            if (IsRunning) 
+            {
+                _disconnectedSubject.OnNext(DisconnectionInfo.Create(DisconnectionType.Exit, _client, null));
+            }
+
             IsRunning = false;
             IsStarted = false;
-            _disconnectedSubject.OnNext(DisconnectionInfo.Create(DisconnectionType.Exit, _client, null));
             _disconnectedSubject.OnCompleted();
         }
 

diff --git a/test/Websocket.Client.Tests/ConnectionTests.cs b/test/Websocket.Client.Tests/ConnectionTests.cs
@@ -146,14 +146,15 @@ public async Task Starting_MultipleTimes_ShouldWorkWithNoExceptions()
         [Fact]
         public async Task Stopping_ShouldWorkCorrectly()
         {
+            var disconnectionCount = 0;
+
             using (var client = _context.CreateClient())
             {
                 client.ReconnectTimeout = TimeSpan.FromSeconds(7);
 
                 string received = null;
                 var receivedCount = 0;
                 var receivedEvent = new ManualResetEvent(false);
-                var disconnectionCount = 0;
                 DisconnectionInfo disconnectionInfo = null;
 
                 client.MessageReceived
@@ -186,13 +187,17 @@ public async Task Stopping_ShouldWorkCorrectly()
                 // check that reconnection is disabled
                 await Task.Delay(8000);
                 Assert.Equal(1, receivedCount);
-                Assert.InRange(disconnectionCount, 1, 2);
+                Assert.Equal(1, disconnectionCount);
                 Assert.Equal(DisconnectionType.ByUser, disconnectionInfo.Type);
                 Assert.Equal(WebSocketCloseStatus.InternalServerError, disconnectionInfo.CloseStatus);
                 Assert.Equal("server error 500", disconnectionInfo.CloseStatusDescription);
                 Assert.False(client.IsRunning);
                 Assert.False(client.IsStarted);
             }
+
+            // Disposing a disconnected socket should not cause DisconnectionHappened to trigger.
+            await Task.Delay(200);
+            Assert.Equal(1, disconnectionCount);
         }
 
         [Fact]