Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Update dependencies and sample project to use ViewBinding #2

Open
wants to merge 1 commit into
base: release
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ buildscript {
ext.kotlin_version = '1.3.72'
repositories {
google()
jcenter()

mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:4.0.1'
classpath 'com.android.tools.build:gradle:4.0.2'
classpath 'com.github.dcendents:android-maven-gradle-plugin:2.0'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
// NOTE: Do not place your application dependencies here; they belong
Expand All @@ -19,8 +18,7 @@ buildscript {
allprojects {
repositories {
google()
jcenter()

mavenCentral()
}
}

Expand Down
1 change: 1 addition & 0 deletions example-viewbinding/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
55 changes: 55 additions & 0 deletions example-viewbinding/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
plugins {
id 'com.android.application'
id 'org.jetbrains.kotlin.android'
id 'kotlin-kapt'
}

android {
compileSdkVersion 31

defaultConfig {
applicationId "com.marianatek.dkouple.viewbinding"
minSdkVersion 23
targetSdkVersion 31
versionCode 1
versionName "1.0"

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}

buildTypes {
release {
minifyEnabled false
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
kotlinOptions {
jvmTarget = '1.8'
}
buildFeatures {
viewBinding true
}
}

dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])

// Add DKouple Library
implementation project(':library')
implementation project(':core')
kapt project(':processor')

// Add Android Recyclerview modules
implementation 'androidx.recyclerview:recyclerview:1.2.1'

implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
implementation 'androidx.appcompat:appcompat:1.4.1'
implementation 'androidx.core:core-ktx:1.3.1'

implementation 'com.squareup.picasso:picasso:2.71828'
implementation 'com.google.android.material:material:1.7.0-alpha01'
}
21 changes: 21 additions & 0 deletions example-viewbinding/proguard-rules.pro
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Add project specific ProGuard rules here.
# You can control the set of applied configuration files using the
# proguardFiles setting in build.gradle.
#
# For more details, see
# http://developer.android.com/guide/developing/tools/proguard.html

# If your project uses WebView with JS, uncomment the following
# and specify the fully qualified class name to the JavaScript interface
# class:
#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
# public *;
#}

# Uncomment this to preserve the line number information for
# debugging stack traces.
#-keepattributes SourceFile,LineNumberTable

# If you keep the line number information, uncomment this to
# hide the original source file name.
#-renamesourcefileattribute SourceFile
23 changes: 23 additions & 0 deletions example-viewbinding/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.marianatek.dkouple.viewbinding">

<application
android:allowBackup="true"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/Theme.DKouple">
<activity
android:name=".MainActivity"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
</application>

</manifest>
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package com.marianatek.dkouple.viewbinding

import android.annotation.SuppressLint
import android.view.View
import com.marianatek.dkouple.viewbinding.databinding.ComponentItemTextBinding
import com.seannajera.dkouple.ComponentViewBinding
import com.seannajera.dkouple.Component
import com.seannajera.dkouple.DKoupleComponent
import com.seannajera.dkouple.DKoupleView
import com.seannajera.dkouple.FactoryView

@SuppressLint("NonConstantResourceId")
Copy link
Contributor

@flopshot flopshot May 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice-to-have AGP 8 will break the code generation feature of DKouple (they keep delaying this change so they might delay it further, but one should assume this time it will happen). This won't break the reflection based layout id lookup from the annotation at runtime in the adapter nor will it break a non-generated factory.

I've never profiled the annotation reflection for performance, but any performance hit was necessary to make the code generation work as well as to make the api look nicer.

Now that annotations won't work for that use case, it would be nice to redesign DKouple to not use them. I'd love to explore using KSP instead which would be WAY easier to maintain than an annotation processor.

This could be a part of a larger/separate issue.

@DKoupleComponent(R.layout.component_item_text, ItemTextView::class)
data class ItemTextComponent(
override val id: String,
val text: String
) : Component

@DKoupleView
class ItemTextView(
@FactoryView view: View
) : ComponentViewBinding<ItemTextComponent, ComponentItemTextBinding>(view) {
override val binding: ComponentItemTextBinding by lazy {
ComponentItemTextBinding.bind(view)
}

override fun onViewUpdate(previous: ItemTextComponent?, current: ItemTextComponent) {
if (previous != current) {
binding.textView.text = current.text
}
}
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package com.marianatek.dkouple.viewbinding

import androidx.appcompat.app.AppCompatActivity
import android.os.Bundle
import com.marianatek.dkouple.viewbinding.databinding.ActivityMainBinding
import com.seannajera.dkouple.ComponentAdapter
import com.seannajera.dkouple.ComponentFactory
import com.seannajera.dkouple.DKoupleComponentFactory

class MainActivity : AppCompatActivity() {

private val componentFactory: ComponentFactory = DKoupleComponentFactory()
private val adapter = ComponentAdapter(componentFactory)

private lateinit var binding: ActivityMainBinding

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
binding = ActivityMainBinding.inflate(layoutInflater)
setContentView(binding.root)

binding.recyclerview.adapter = adapter

val componentsList = mutableListOf<ItemTextComponent>()
for (i in 0..1000) {
componentsList.add(ItemTextComponent("$i", "Text Component #$i"))
}

adapter.applyComponents(componentsList)
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:aapt="http://schemas.android.com/aapt"
android:width="108dp"
android:height="108dp"
android:viewportWidth="108"
android:viewportHeight="108">
<path android:pathData="M31,63.928c0,0 6.4,-11 12.1,-13.1c7.2,-2.6 26,-1.4 26,-1.4l38.1,38.1L107,108.928l-32,-1L31,63.928z">
<aapt:attr name="android:fillColor">
<gradient
android:endX="85.84757"
android:endY="92.4963"
android:startX="42.9492"
android:startY="49.59793"
android:type="linear">
<item
android:color="#44000000"
android:offset="0.0" />
<item
android:color="#00000000"
android:offset="1.0" />
</gradient>
</aapt:attr>
</path>
<path
android:fillColor="#FFFFFF"
android:fillType="nonZero"
android:pathData="M65.3,45.828l3.8,-6.6c0.2,-0.4 0.1,-0.9 -0.3,-1.1c-0.4,-0.2 -0.9,-0.1 -1.1,0.3l-3.9,6.7c-6.3,-2.8 -13.4,-2.8 -19.7,0l-3.9,-6.7c-0.2,-0.4 -0.7,-0.5 -1.1,-0.3C38.8,38.328 38.7,38.828 38.9,39.228l3.8,6.6C36.2,49.428 31.7,56.028 31,63.928h46C76.3,56.028 71.8,49.428 65.3,45.828zM43.4,57.328c-0.8,0 -1.5,-0.5 -1.8,-1.2c-0.3,-0.7 -0.1,-1.5 0.4,-2.1c0.5,-0.5 1.4,-0.7 2.1,-0.4c0.7,0.3 1.2,1 1.2,1.8C45.3,56.528 44.5,57.328 43.4,57.328L43.4,57.328zM64.6,57.328c-0.8,0 -1.5,-0.5 -1.8,-1.2s-0.1,-1.5 0.4,-2.1c0.5,-0.5 1.4,-0.7 2.1,-0.4c0.7,0.3 1.2,1 1.2,1.8C66.5,56.528 65.6,57.328 64.6,57.328L64.6,57.328z"
android:strokeWidth="1"
android:strokeColor="#00000000" />
</vector>
Loading