Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Closes #2563
Overview of changes:
After investigating #2563, the image annotation started breaking after converting to use the slots API.
According to Vue's documentation, content passed by the slots API are considered to be owned by the parent component that passes them in and so styles do not apply to them.
A separate CSS rule to target all elements within the div that holds the slot is added to override the parent's styles. This fixed the issue and the problem no longer persists.
Some screenshots:
Anything you'd like to highlight/discuss:
Testing instructions:
Testing can be done locally by navigating to the
docs
folder and runningnpm markbind serve -d -o userGuide/components/imagesAndDiagrams.md
Proposed commit message: (wrap lines at 72 characters)
Fix broken annotation label
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):