unset sticky bit when clearing working directory #483
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donny-wong
requested changes
Jan 25, 2024
donny-wong
approved these changes
Jan 25, 2024
david-yz-liu
approved these changes
Jan 25, 2024
donny-wong
pushed a commit
to donny-wong/markus-autotesting
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During test setup, instructor files are copied to a worker directory. Any directories in the instructor files have the sticky bit set to prevent them from being deleted by worker users running student submissions.
However, if scripts copy directories from within instructor files to another location, the permissions (including the sticky bit) will be copied as well. Test cleanup is performed by a different user, and the presence of the sticky bit prevents deletion of such directories.
This PR explicitly unsets the sticky bit on all directories in the autotest worker directory before attempting to delete the contents of the directory, as part of other permissions changes required.
Tested by setting up an assignment which copies a directory from the instructor files to the current working directory. In current master, the folder remains after cleanup is attempted. With this PR, the folder is deleted as expected.