Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint rules #68

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Update eslint rules #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9ee9b2
Update eslint rules
Marketionist Oct 10, 2024
34d0bbb
Update valid-jsdoc
Marketionist Oct 10, 2024
5acfde8
Fix linting
Marketionist Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
332 changes: 171 additions & 161 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,193 +26,203 @@
"root": true,
"rules": {
// Possible Errors
"comma-dangle": [2, "never"],
"no-cond-assign": 2,
"no-console": 0,
"no-constant-condition": 2,
"no-control-regex": 2,
"no-debugger": 2,
"no-dupe-args": 2,
"no-dupe-keys": 2,
"no-duplicate-case": 2,
"no-empty-character-class": 2,
"comma-dangle": ["error", {
"arrays": "always",
"objects": "never",
"imports": "never",
"exports": "never",
"functions": "never"
}],
"no-cond-assign": "error",
"no-console": "off",
"no-constant-condition": "error",
"no-control-regex": "error",
"no-debugger": "error",
"no-dupe-args": "error",
"no-dupe-keys": "error",
"no-duplicate-case": "error",
"no-empty-character-class": "error",
"no-empty": ["error", { "allowEmptyCatch": true }],
"no-ex-assign": 2,
"no-extra-boolean-cast": 2,
"no-ex-assign": "error",
"no-extra-boolean-cast": "error",
"no-extra-parens": ["error", "all", {
"nestedBinaryExpressions": false
}],
"no-extra-semi": 2,
"no-func-assign": 2,
"no-inner-declarations": 2,
"no-invalid-regexp": 2,
"no-irregular-whitespace": 2,
"no-negated-in-lhs": 2,
"no-obj-calls": 2,
"no-regex-spaces": 2,
"no-sparse-arrays": 2,
"no-unexpected-multiline": 2,
"no-unreachable": 2,
"use-isnan": 2,
"valid-jsdoc": [2, {
"no-extra-semi": "error",
"no-func-assign": "error",
"no-inner-declarations": "error",
"no-invalid-regexp": "error",
"no-irregular-whitespace": "error",
"no-negated-in-lhs": "error",
"no-obj-calls": "error",
"no-regex-spaces": "error",
"no-sparse-arrays": "error",
"no-unexpected-multiline": "error",
"no-unreachable": "error",
"use-isnan": "error",
"valid-jsdoc": ["error", {
"requireReturn": false,
"requireParamDescription": false,
"requireReturnDescription": false,
"requireParamDescription": true,
"requireReturnDescription": true,
"prefer": {
"return": "returns"
}
}],
"valid-typeof": 2,
"valid-typeof": "error",

// Best Practices
"accessor-pairs": 2,
"block-scoped-var": 2,
"accessor-pairs": "error",
"block-scoped-var": "error",
"complexity": ["error", { "max": 20 } ],
"consistent-return": 0,
"curly": 2,
"default-case": 2,
"dot-location": [2, "property"],
"dot-notation": 2,
"eqeqeq": 2,
"guard-for-in": 2,
"no-alert": 2,
"no-caller": 2,
"no-case-declarations": 2,
"no-div-regex": 2,
"no-else-return": 1,
"no-empty-pattern": 2,
"no-eq-null": 2,
"no-eval": 2,
"no-extend-native": 2,
"no-extra-bind": 2,
"no-fallthrough": 2,
"no-floating-decimal": 2,
"no-implicit-coercion": 0,
"no-implied-eval": 2,
"no-invalid-this": 0,
"no-iterator": 2,
"no-labels": 2,
"no-lone-blocks": 2,
"no-loop-func": 2,
"no-magic-numbers": ["error", { "ignore": [0, -1, 1, 2, 8000, 9000], "ignoreArrayIndexes": true }],
"no-multi-spaces": 2,
"no-multi-str": 0,
"no-native-reassign": 2,
"no-new-func": 2,
"no-new-wrappers": 2,
"no-new": 0,
"no-octal-escape": 2,
"no-octal": 2,
"no-param-reassign": 2,
"no-process-env": 0,
"no-proto": 2,
"no-redeclare": 2,
"no-return-assign": 2,
"no-script-url": 2,
"no-self-compare": 2,
"no-sequences": 2,
"no-throw-literal": 2,
"no-unused-expressions": [2, { "allowShortCircuit": true }],
"no-useless-call": 2,
"no-useless-concat": 2,
"no-void": 2,
"no-warning-comments": 0,
"no-with": 2,
"radix": 2,
"vars-on-top": 1, // FIXME should be enabled at some point
"wrap-iife": [2, "inside"],
"yoda": [2, "never", { "exceptRange": true }],
"consistent-return": "off",
"curly": "error",
"default-case": "error",
"dot-location": ["error", "property"],
"dot-notation": "error",
"eqeqeq": "error",
"guard-for-in": "error",
"no-alert": "error",
"no-caller": "error",
"no-case-declarations": "error",
"no-div-regex": "error",
"no-else-return": "warn",
"no-empty-pattern": "error",
"no-eq-null": "error",
"no-eval": "error",
"no-extend-native": "error",
"no-extra-bind": "error",
"no-fallthrough": "error",
"no-floating-decimal": "error",
"no-implicit-coercion": "off",
"no-implied-eval": "error",
"no-invalid-this": "off",
"no-iterator": "error",
"no-labels": "error",
"no-lone-blocks": "error",
"no-loop-func": "error",
"no-magic-numbers": ["error", {
"ignore": [0, -1, 1, 2, 8000, 9000],
"ignoreArrayIndexes": true
}],
"no-multi-spaces": "error",
"no-multi-str": "off",
"no-native-reassign": "error",
"no-new-func": "error",
"no-new-wrappers": "error",
"no-new": "off",
"no-octal-escape": "error",
"no-octal": "error",
"no-param-reassign": "error",
"no-process-env": "off",
"no-proto": "error",
"no-redeclare": "error",
"no-return-assign": "error",
"no-script-url": "error",
"no-self-compare": "error",
"no-sequences": "error",
"no-throw-literal": "error",
"no-unused-expressions": ["error", { "allowShortCircuit": true }],
"no-useless-call": "error",
"no-useless-concat": "error",
"no-void": "error",
"no-warning-comments": "off",
"no-with": "error",
"radix": "error",
"vars-on-top": "warn", // Should be enabled at some point
"wrap-iife": ["error", "inside"],
"yoda": ["error", "never", { "exceptRange": true }],

// Strict Mode
"strict": [0, "global"],
"strict": ["off", "global"],

// Variables
"init-declarations": 0,
"no-catch-shadow": 2,
"no-delete-var": 2,
"no-label-var": 2,
"no-shadow-restricted-names": 2,
"no-shadow": 2,
"no-undef-init": 2,
"no-undef": 2,
"no-undefined": 0,
"no-unused-vars": 1,
"no-use-before-define": 2,
"init-declarations": "off",
"no-catch-shadow": "error",
"no-delete-var": "error",
"no-label-var": "error",
"no-shadow-restricted-names": "error",
"no-shadow": "error",
"no-undef-init": "error",
"no-undef": "error",
"no-undefined": "off",
"no-unused-vars": "warn",
"no-use-before-define": "error",

// Stylistic Issues
"array-bracket-spacing": [2, "never"],
"block-spacing": 2,
"brace-style": [2, "1tbs", { "allowSingleLine": true }],
"camelcase": 0,
"comma-spacing": [2, {"before": false, "after": true}],
"comma-style": [2, "last"],
"computed-property-spacing": [2, "never"],
"consistent-this": [2, "that"],
"eol-last": 2,
"func-names": 0,
"func-style": 0,
"id-length": 0,
"id-match": 0,
"indent": ["error", 4, {
"SwitchCase": 1
}],
"jsx-quotes": 0,
"key-spacing": [2, {"beforeColon": false, "afterColon": true}],
"linebreak-style": [2, "unix"],
"lines-around-comment": 0,
"max-nested-callbacks": [2, 5],
"new-cap": 2,
"new-parens": 2,
"newline-after-var": 2,
"no-array-constructor": 2,
"no-continue": 2,
"no-inline-comments": 0,
"no-lonely-if": 2,
"no-mixed-spaces-and-tabs": 2,
"no-multiple-empty-lines": [2, {"max": 2}],
"no-negated-condition": 2,
"no-nested-ternary": 2,
"no-new-object": 2,
"no-restricted-syntax": 0,
"no-spaced-func": 0,
"no-ternary": 0,
"no-trailing-spaces": 2,
"no-underscore-dangle": 0,
"no-unneeded-ternary": 2,
"object-curly-spacing": [2, "always", {
"array-bracket-spacing": ["error", "never"],
"block-spacing": "error",
"brace-style": ["error", "1tbs", { "allowSingleLine": true }],
"camelcase": "off",
"comma-spacing": ["error", { "before": false, "after": true }],
"comma-style": ["error", "last"],
"computed-property-spacing": ["error", "never"],
"consistent-this": ["error", "that"],
"eol-last": "error",
"func-names": "off",
"func-style": "off",
"id-length": "off",
"id-match": "off",
"indent": ["error", 4, { "SwitchCase": 1 }],
"jsx-quotes": "off",
"key-spacing": ["error", { "beforeColon": false, "afterColon": true }],
"linebreak-style": ["error", "unix"],
"lines-around-comment": "off",
"max-nested-callbacks": ["error", 5],
"new-cap": "error",
"new-parens": "error",
"newline-after-var": "error",
"no-array-constructor": "error",
"no-continue": "error",
"no-inline-comments": "off",
"no-lonely-if": "error",
"no-mixed-spaces-and-tabs": "error",
"no-multiple-empty-lines": ["error", { "max": 2 }],
"no-negated-condition": "error",
"no-nested-ternary": "error",
"no-new-object": "error",
"no-restricted-syntax": "off",
"no-spaced-func": "off",
"no-ternary": "off",
"no-trailing-spaces": "error",
"no-underscore-dangle": "off",
"no-unneeded-ternary": "error",
"object-curly-spacing": ["error", "always", {
"objectsInObjects": true,
"arraysInObjects": true
}],
"one-var": [2, "never"],
"operator-assignment": 2,
"operator-linebreak": [2, "after"],
"padded-blocks": 0,
"quote-props": [2, "consistent-as-needed"],
"quotes": [2, "single", "avoid-escape"],
"require-jsdoc": 2,
"semi-spacing": [2, {"before": false, "after": true}],
"semi": [0, "always"],
"sort-vars": 0,
"keyword-spacing": 2,
"space-before-blocks": 2,
"space-before-function-paren": ["error", { "anonymous": "always", "named": "always" }],
"space-in-parens": [2, "never"],
"space-infix-ops": 2,
"space-unary-ops": 2,
"spaced-comment": [2, "always", {
"one-var": ["error", "never"],
"operator-assignment": "error",
"operator-linebreak": ["error", "after"],
"padded-blocks": "off",
"quote-props": ["error", "consistent-as-needed"],
"quotes": ["error", "single", "avoid-escape"],
"require-jsdoc": "error",
"semi-spacing": ["error", { "before": false, "after": true }],
"semi": ["error", "always"],
"sort-vars": "off",
"keyword-spacing": "error",
"space-before-blocks": "error",
"space-before-function-paren": ["error", {
"anonymous": "always",
"named": "always"
}],
"space-in-parens": ["error", "never"],
"space-infix-ops": "error",
"space-unary-ops": "error",
"spaced-comment": ["error", "always", {
"exceptions": ["-", "+", "!"]
}],
"wrap-regex": 2,
"wrap-regex": "error",

// ES6
"arrow-parens": [2, "always"],
"arrow-parens": ["error", "always"],

// Legacy
"max-depth": [2, 4],
"max-len": [2, 120],
"max-params": [2, 5],
"max-statements": 0,
"no-bitwise": 2,
"no-plusplus": 0
"max-depth": ["error", 4],
"max-len": ["error", 120],
"max-params": ["error", 5],
"max-statements": "off",
"no-bitwise": "error",
"no-plusplus": "off"
}
}
2 changes: 1 addition & 1 deletion tests/test1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ if (
const pathToDirectory1 = path.join(__dirname, '..', 'utils');
const pathToDirectory2 = path.join(__dirname);

const allFiles = await readDirectories([pathToDirectory1, pathToDirectory2]);
const allFiles = await readDirectories([pathToDirectory1, pathToDirectory2,]);

console.log('allFiles array:');
allFiles.map((value) => {
Expand Down
2 changes: 1 addition & 1 deletion utils/retry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ async function retryIfFalse ({
`${ERROR_FAILED_FUNCTION_TO_EXECUTE} ${functionToExecute.name} x ${attemptsValue}`
));
}
}, waitTimeValue)
}, waitTimeValue);
});

return result;
Expand Down
Loading