Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix birthday informations from facebook: birthday is empty if permiss… #72

Closed
wants to merge 1 commit into from

Conversation

marvasDE
Copy link

@marvasDE marvasDE commented Mar 7, 2018

…ion is denied (therefore it was be converted to current date) + fix date format

Facebook's date format is american (MM/dd/yyyy) and have to be given to the date method to convert correctly. See the comment from chougron in the old PR #22, which had the same issue.

…ion is denied (therefore it was be converted to current date) + fix date format
@sprankhub
Copy link
Collaborator

I am not sure if the date needs to be converted to a different format. However, checking for an empty birthday definitely makes sense and fixes the issue that the birthday is set to the current date.

@Marko-M
Copy link
Owner

Marko-M commented Dec 6, 2018

Thanks, fixed with #81

@Marko-M Marko-M closed this Dec 6, 2018
@sprankhub
Copy link
Collaborator

#81 actually just fixed the "date of birth set to current date issue". I am not sure if the date conversion proposed in this PR needs to be included. Our app is not allowed to get the date of birth, so I cannot test. However, if the API returns the format as defined in https://developers.facebook.com/docs/graph-api/reference/user/ under birthday, the format is indeed either MM/DD/YYYY or MM/DD or YYYY. So I guess some conversion needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants