Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI pipeline #5

Merged
merged 36 commits into from
Oct 21, 2024
Merged

Add CI pipeline #5

merged 36 commits into from
Oct 21, 2024

Conversation

adam-ce
Copy link
Contributor

@adam-ce adam-ce commented Oct 21, 2024

This adds a CI pipeline:

  • you might need to enable github pages deployment from actions: Repository -> Settings -> Pages -> Source -> Github Actions
  • it'll work for any clone, for the main branch. this means, that you can check the output of pull requests (as long as they activated gh pages and do the pull request from their main branch). e.g.: https://adam-ce.github.io/Material-Qt/
  • I didn't test the apk, just threw it in, as it didn't cost much.
  • Qt changed the naming of it's wasm build location. as a result, the aqt installer started failing. as a consequence of that, the gh pages action also started failing. see Installing WebAssembly Qt 6.7.0 fails miurahr/aqtinstall#779. a workaround is in place, but works only for 6.7 (not 6.8).
  • I'm planning to build the wasm qt version from source in gh pages. This would allow to disable several Qt modules and therefore reduce binary size. I'll do sth similar for MM, but don't expect it soon, as my patience for gh actions is exhausted again for some time ;)
  • I changed your CMake setup. calling a python script for asynchronous globing is not necessary and broke the CI build (iirc the path files were for windows, and didn't work on linux).
  • The windows and linux builds only test compilers for a wider compatibility. If you should ever have unit tests, you could run them in these CI actions.
  • I had to debug qrc paths and added code for that in your main() function. feel free to remove it again. I kept it, as i find it convenient in my project :)

Copy link
Owner

@MarkoStanojevic12 MarkoStanojevic12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning for the python script is me not being able to make file(GLOB) work. So you helped out a lot with that. Thanks :D

@MarkoStanojevic12 MarkoStanojevic12 merged commit 72656d5 into MarkoStanojevic12:main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants