ExtUI Align internal data types with return data types #27542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ExtUI functions the internal data type and the return data types were inconsistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some ExtUI functions the internal data types and the return data types are inconsistent:
celsius_float_t getTargetTemp_celsius(const heater_t); --> Internally uses celsius_t
celsius_float_t getTargetTemp_celsius(const extruder_t); --> Internally uses celsius_t
float getActualFan_percent(const fan_t); --> internally uses uint8_t
float getTargetFan_percent(const fan_t); --> internally uses uint8_t
This PR changes the return types of the above mentioned functions to align with the internally used data types.
Requirements
None
Benefits
Slightly higher efficiency when using the ExtUI because some data type conversions are not needed anymore.
Related Issues
I posted about this topic before to test the waters:
#27529