rename CEnvelope::ValueRange and add comment

Marmare314 · Oct 7, 2023 · 63da1ae · 63da1ae
1 parent 0d4d593
commit 63da1ae
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/game/editor/editor.cpp b/src/game/editor/editor.cpp
@@ -5314,7 +5314,7 @@ void CEditor::UpdateZoomEnvelopeY(const CUIRect &View)
 
 void CEditor::ResetZoomEnvelope(const std::shared_ptr<CEnvelope> &pEnvelope, int ActiveChannels)
 {
-	auto [Bottom, Top] = pEnvelope->GetValueRange(ActiveChannels);
+	auto [Bottom, Top] = pEnvelope->ValueRange(ActiveChannels);
 	float EndTime = pEnvelope->EndTime();
 	float ValueRange = absolute(Top - Bottom);
 

diff --git a/src/game/editor/mapitems/envelope.cpp b/src/game/editor/mapitems/envelope.cpp
@@ -73,7 +73,7 @@ void CEnvelope::Resort()
 	}
 }
 
-std::pair<float, float> CEnvelope::GetValueRange(int ChannelMask)
+std::pair<float, float> CEnvelope::ValueRange(int ChannelMask)
 {
 	float Top = -std::numeric_limits<float>::infinity();
 	float Bottom = std::numeric_limits<float>::infinity();

diff --git a/src/game/editor/mapitems/envelope.h b/src/game/editor/mapitems/envelope.h
@@ -3,7 +3,6 @@
 
 #include <game/client/render.h>
 
-#include "base/color.h"
 #include "envelope_point.h"
 
 class CEnvelope
@@ -22,10 +21,13 @@ class CEnvelope
 	explicit CEnvelope(EType Type);
 	explicit CEnvelope(int NumChannels);
 
-	std::pair<float, float> GetValueRange(int ChannelMask);
+	// Get the range of the values in the envelope (including tangent handles)
+	std::pair<float, float> ValueRange(int ChannelMask);
+
 	void Eval(float Time, float &Volume);
 	void Eval(float Time, CTransform &CTransform);
 	void Eval(float Time, ColorRGBA &Color);
+
 	void AddPoint(float Time, float Volume);
 	void AddPoint(float Time, CTransform Transform);
 	void AddPoint(float Time, ColorRGBA Color);