[gui]: Use TRequestFilter.GetByName when adding a new filter

MartinDrab · Jun 22, 2019 · 86bb11c · 86bb11c
1 parent 7024f15
commit 86bb11c
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/gui/FillterForm.pas b/gui/FillterForm.pas
@@ -477,7 +477,6 @@
   hc : TColor;
   err : Cardinal;
   passTarget : TRequestFilter;
-  nameExists : Boolean;
   newName : WideString;
 begin
 f := Nil;
@@ -534,21 +533,14 @@
     FilterValueComboBox.Text + '-' +
     FilterActionComboBox.Text;
 
-  nameExists := False;
-  For f In FFilterList Do
-    begin
-    nameExists := f.Name = newName;
-    If nameExists Then
-      Break;
-    end;
-
-  f := Nil;
-  If nameExists Then
+  f := TRequestFilter.GetByName(newName, FFilterList);
+  If Assigned(f) Then
     begin
     ErrorMessage('The filter is already present in the list');
     Exit;
     end;
 
+  f := Nil;
   f := TRequestFilter.NewInstance(rt);
   If Not Assigned(f) Then
     Exit;