Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sonar.yml #12

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Update sonar.yml #12

merged 5 commits into from
Jul 22, 2024

Conversation

karen-avetisyan-mc
Copy link
Contributor

@karen-avetisyan-mc karen-avetisyan-mc commented Jul 22, 2024 •
edited
Loading

Updating version to 1.21.1

PR checklist

  • An issue/feature request has been created for this PR
  • Pull Request title clearly describes the work in the pull request and the Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response.
  • File the PR against the master branch
  • The code in this PR is covered by unit tests

Link to issue/feature request: add the link here

Description

A clear and concise description of what is this PR for and any additional info might be useful for reviewing it.

@karen-avetisyan-mc
Update sonar.yml
a534dc0 
Updating version to 1.21.1
@karen-avetisyan-mc karen-avetisyan-mc self-assigned this Jul 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rfeelin rfeelin added the safe The PR has been reviewed by Mastercard and has been validated to be safe label Jul 22, 2024
@karen-avetisyan-mc karen-avetisyan-mc removed the request for review from danny-gallagher July 22, 2024 13:07
joseph-neeraj
joseph-neeraj previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@joseph-neeraj joseph-neeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-neeraj joseph-neeraj self-requested a review July 22, 2024 13:19
joseph-neeraj
joseph-neeraj approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@joseph-neeraj joseph-neeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@karen-avetisyan-mc karen-avetisyan-mc merged commit 6c70d2a into main Jul 22, 2024
4 of 7 checks passed
@karen-avetisyan-mc karen-avetisyan-mc deleted the karen-avetisyan-mc-patch-1 branch July 22, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-neeraj joseph-neeraj Awaiting requested review from joseph-neeraj

Assignees

@karen-avetisyan-mc karen-avetisyan-mc

Labels
safe The PR has been reviewed by Mastercard and has been validated to be safe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karen-avetisyan-mc @joseph-neeraj @rfeelin