Add leading slash to URL Path in getBaseUrlString function, if one does not already exist #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
karen-avetisyan-mc
added
the
safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
masterbranchLink to issue/feature request: #13
Description
When the URL path doesn't have a leading slash, for example, when using the
JoinPathfunction,getBaseUrlStringdoes not correctly concatenate the host and path components. This is handled correctly in the stdlib net/url package, for example, when callingurl.String().This MR adds a similar check to the one used in net/url, to correctly handle this scenario.