Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10-final_vBrusentsov #441

Closed
wants to merge 12 commits into from
Closed

10-final_vBrusentsov #441

wants to merge 12 commits into from

Conversation

vBrusentsov
Copy link
Collaborator

@vBrusentsov vBrusentsov commented Dec 23, 2023

Copy link
Contributor

@MZabolotnev MZabolotnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все круто, гарна робота! Є пару зауважень:
image

  1. Вирівнять фільтри по одній лініі
  2. Тест в титулкі Games без відступу
  3. Краще зробити картки в одну колонку, і там теж є трохи біда з текстом
    image
  4. Відступи різні
    image
    Цей скрін відрізняється від інших
    image
    Обрізаний плейсхолдер паролю

@vBrusentsov vBrusentsov changed the title feat: add footer and adaptive layout 10-final_vBrusentsov Dec 27, 2023
@vBrusentsov vBrusentsov added the Ready to final review The pr is ready for review of random mentor label Dec 28, 2023
MZabolotnev
MZabolotnev previously approved these changes Dec 28, 2023
@vladyslav-yermolin-moc
Copy link
Collaborator

Hey, @vBrusentsov, you should remove changes of the files, not delete files. I've wrote you simple way in tg

  • make a new branch from the fresh main
  • add you files to docs folder
  • create pr

@vladyslav-yermolin-moc
Copy link
Collaborator

OK, I'm closing this pr and waiting for the correct one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final reviewer assigned Ready to final review The pr is ready for review of random mentor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants