-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make building on macOS more convenient #193
base: develop
Are you sure you want to change the base?
Conversation
detect OS by running uname set library options accordingly
@DanEble I've tested your changes on my system and it work well but how do you say,
Need more investiagation... |
ifndef OS | ||
OS:=$(shell uname) | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a little more research. According to https://stackoverflow.com/a/12099167,
OS
will be set in the environment on Windows systems, so this should work fine for Windows in addition to systems with uname
.
This might be down to a udev rule missing somewhere perhaps? I'm not fully familiar with macOS on the backend.. But it still is unix |
Probably going in the same direction, but would it be possible to make this installable through the macOS package manager https://github.com/Homebrew/brew? Edit: actually reading through this issue and the linked issues made me realise we are not that far yet. Sorry for the disturbance. |
I just tested this branch merged to the head of main repo, Installed HIDAPI from homebrew, on macOS BigSur and now it is working very reliably! The bin still has to run with SUDO tho. I will setup a service for it to update the color periodically, I shall come back to report on this if anything still goes well. I'm not sure if it was the changes to BigSur or to the project itself that resolved the issue however. I think I was running macOS Catalina when I made my previous reply |
detect OS by running uname
set library options accordingly
@MatMoul The main question I have is whether
$(shell uname)
will work in all the environments in which you want to build this program.