Conserved quantities are transferred by default during phagocytosis #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to Issue #307, cells by default ingest 100% of internalized substrates when eating another cell.
In response to Issue #307, cells by default ingest 100% of conserved custom variables when eating another cell.
update version number to 1.14.1-development
In response to Issue #307, cells by default ingest 100% of internalized substrates when eating another cell. (Note that the values for std::vector<bool> fraction_tranferred_when_ingested in Basic_Agent is *overwritten* by constructors in the cell Phenotype, so we have ot do it there.)
drbergman
requested changes
Oct 14, 2024
core/PhysiCell_cell.cpp
Outdated
| // so that each daughter cell gets half of the original ; | ||
| for( int nn = 0 ; nn < custom_data.variables.size() ; nn++ ) | ||
| { | ||
| custom_data.variables[nn].conserved_quantity = true; |
There was a problem hiding this comment.
I think we want to delete this line. we don't want to change the boolean value here.
There was a problem hiding this comment.
oof, right. I think I was forcing it during testing since it wasn't being parsed.
There was a problem hiding this comment.
did the change, thank you!
remove testing line that set all custom variables to `conserved = true` that was mistakenly left in. Thanks, Daniel!
fixed the comment
|
I changed the comment about the conservation for phagocytosis. Sorry about that second commit because I accidentally changed two lines in the first one. |
drbergman
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to Issue #307, cells by default ingest 100% of internalized substrates and conserved variables when eating another cell.