-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove macos-12 from ci #332
base: development
Are you sure you want to change the base?
remove macos-12 from ci #332
Conversation
- record the value of applies_to_dead - use v3 for export (to make sharing easier)
…-in-output write random_seed to output/random_seed.txt
…t-random-seeds fix bug reading large random seeds
fix bug in export rules
fix buffer bug in writing coords in xml
…o-makefile add immune_test_2024 to Makefiles as immune-function-sample
…e-initialization initialize total_attack_time at 0.0
…om-abspath Fix create output from abspath
gh actions deprecation upcoming
remove macos-12 from ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I forgot about this. We are getting close. Thanks for the reminder :)
We shouldn't just remove it, because 12 and 13 are still x86_64 (non arm64 or M1) chips, and we should test on these as long as we can. So best would be to just change every macos-12 to macos-13, and pray that it works.
Same thing for the build_binaries script, which is building the universal (x86 and arm86) binaries for mac, for this we still need a x86_64 environment.
If you have time to do this, also for the build_binaries.yml, that's awesome, otherwise I can do it hopefully next week !
done! now we just hold our breath for the tests... |
gh actions deprecation upcoming silence gcc@13 warnings in build binaries
0b1ff2c
to
d02de52
Compare
oops...just realized I updated this branch to merge with the rc1 test branch...that means that we cannot merge this PR unless we like all the PRs combined in 1.14.1-rc1 branch. I think we will, but noting it here just in case |
gh actions deprecation upcoming
still have macos-14 ci