Modernize Python metadata (local) #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmatera the failures here are failures in the core system. While I am currently working on fixing those problems, we might consider merging this in since it has been a while lingering. Your thoughts? |
|
Actually, this PR seems to produce more errors. In my opinion, to merge this would make it harder to determine the origin of this and the previous failures. |
Ok. Hopefully, I will have the others addressed within a day or so. |
Cython is fussier about this?
3.11 seems to use to require more stringent cython. While this is a good thing. Right now we should focus on one issue at a time. The issue here is TOM, not 3.11 Cython stringencies
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 20, 2024
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Our Mathics package is outdated (and also the interface shows test failures in CI - e.g. in https://github.com/sagemath/sage/actions/runs/7 894201915/job/21638423818#step:14:3279) Trying to update Mathics reveals more dependencies, include scikit-image and llvm-lite. Here we reduce it to a "pip" package to simplify maintenance of the package on our side. The latest released version 6.0.4 fails to install in Sage because of rigid version constraints. We are using the current HEAD version (7.0.0dev), which includes - Mathics3/mathics-core#1014 - Mathics3/mathics-core#1034 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37395 Reported by: Matthias Köppe Reviewer(s): Matthias Köppe, Sebastian Oehms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local fork of #1013 - Adds redoes packaging in the form that 3.12 is going to need since setuptools is deprecated.
In the process, something happened with the way that Cython gets run and we were then getting lots of Cython type annotation mismatch failures. So these have been corrected.
We could split this into just the Cython corrections and then apply the packaging toml changes in #1013.
Your thoughts? @mmatera and @mkoeppe