Misc doctest and pytrest fixes #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc_even_if_error is not defined; keep_going is?
mathics/docpipeline.py:
remove find_texdata_folder(): it is not used and it also refers to a nonexistent
class element
test_case(... fail: Optional[]...= ...) allows an explicit None to be passed.
None was not tested for in using fail(). Make not optional
call to doctest_pripile.print_and_log missing f-string specifier.
Not sure why we need the for loop.
start_time needs to be initialized
test/builtin/files_io/test_importexport.py:
test was pollutes local file sytem with 123.txt
Ideally *None* of the tests would work in the local filesystem; a
temp filesystem is okay though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some doctest and pytest bugs...
test.parameters.{doc_even_if_error,keep_going}:
doc_even_if_erroris not defined;keep_going is.mathics/docpipeline.py:
remove find_texdata_folder(): it is not used and it also refers to a nonexistent class element
test_case(... fail: Optional[]...= ...)allows an explicit None to be passed.Nonewas not tested for in usingfail(). Make parameter not optionalcall to doctest_pripile.print_and_log missing f-string specifier. Not sure why we need the for loop.
start_time needs to be initialized
test/builtin/files_io/test_importexport.py:
123.txt. Ideally None of the tests would work in the local filesystem; a temporary file system is okay though.