Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileNameDrop[] #1141

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Add FileNameDrop[] #1141

merged 6 commits into from
Oct 22, 2024

Conversation

rocky
Copy link
Member

@rocky rocky commented Oct 21, 2024

Left to do are changes with mixed negative and positive to integer arg values. I don't understand the behavior though.

And this isn't needed for the ChemTools loader anyway. (But ChemTools has other bugs that still need work).

@rocky rocky requested a review from mmatera October 21, 2024 09:01
@rocky rocky marked this pull request as draft October 21, 2024 09:01
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had tested locally and works the last time... Let me see what is happening.

@mmatera
Copy link
Contributor

mmatera commented Oct 21, 2024

If the second coefficient is negative, and saturates the elements in the math, the result should be the empty string. Instead, I am getting

In[1]:=  FileNameDrop["a/b/c", -3]
Out[1]= "a/b/c"

In[2]:=  FileNameDrop["a/b/c", -4]
Out[2]= "c"

Other cases seem to work fine.

@rocky rocky marked this pull request as ready for review October 22, 2024 12:32
@rocky
Copy link
Member Author

rocky commented Oct 22, 2024

FileNameDrop["a/b/c", -3]

Fixed in more recent commits.

@rocky rocky merged commit 744cbe0 into master Oct 22, 2024
11 checks passed
@rocky rocky deleted the add-FileNameDrop branch October 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants