-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start Operators with no meaning section #1171
Conversation
Isn't this symbol already contained in the Mathics script tables? |
That is, they can take more than two arguments. The operator appears in betweek all operands.
Yes, One day after the operator table in MathicsScanner is completed, we might be able to use the information there and create classes from generic operators. Unfortunately, we aren't close to having that done. |
I've been thinking about this some more, and there is probably a way to get closer by having a generic "no-meaning" class, of which "Star" is an instance. And with this, we can probably plug in more of what we currently have on the MathicsScanner operator YML side. |
It would be awesome to be able to load all the "operators without a meaning" from mathics-scanner. We could have a "mother class" as we have for NamedColors, and then fill it with the entries inside of Mathics scanner tables that are not associated to already loaded symbols. |
@aravindh-krishnamoorthy If you need the Star implemented as an operator for Rubi, this branch can be used. However, I will be reworking the code to be more generic and hook it into a list of operators that do not have any pre-defined meaning. This list of operators will be maintained in MathicsScanner. However, that may take a bit more time. I'll keep this branch as is in the interim. |
""" | ||
|
||
# Note: grouping must be Python string, not a Symbol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be OK if in the class definition, we use a Python string, if we convert it later into a Symbol. So, it would be a problem of contribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it out, and indeed grouping
is used to build a Python str
, that is parsed as a pattern object for defining formatting and boxing rules. So probably it is OK to keep is as a str.
I think we can merge this as it is, adding a comment at the beginning of |
@mmatera Please look this over when you have a chance to see if this "no-meaning" Star operator is done properly.
@axkr says that it would be needed for Rubi.