-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try Rubi as a git submodule #1179
Conversation
@rocky, I think this would be OK once mathics-ruby loads and works properly. By now, I would do the opposite: add a github-action test on mathics-ruby, and check against the branches of mathics-core that improve the required support. |
Yes, that makes sense. But here we need #1176 to finish. This corrects some bugs in handling the "optional" operator in pattern matching. When you get a chance, please look that over since you know far more about Mathics3's pattern-matching code (and WMA) than I. Right now, these changes are pretty small. |
Indeed, this sounds good once basic Rubi starts working... |
Now that Rubi has merged, this is your last chance to weigh in before we merge this. Of course, in order to use Rubi, you'll have to use a branch to make TimeConstrained work. @aravindh-krishnamoorthy started a discussion thread for longer-term solutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's try this. LGTM
Thoughts about doing this?
@aravindh-krishnamoorthy ?