Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Rubi as a git submodule #1179

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Try Rubi as a git submodule #1179

merged 3 commits into from
Dec 20, 2024

Conversation

rocky
Copy link
Member

@rocky rocky commented Nov 21, 2024

Thoughts about doing this?
@aravindh-krishnamoorthy ?

@rocky rocky requested a review from mmatera November 21, 2024 12:21
@mmatera
Copy link
Contributor

mmatera commented Nov 21, 2024

@rocky, I think this would be OK once mathics-ruby loads and works properly. By now, I would do the opposite: add a github-action test on mathics-ruby, and check against the branches of mathics-core that improve the required support.

@rocky rocky marked this pull request as draft November 21, 2024 13:43
@rocky
Copy link
Member Author

rocky commented Nov 21, 2024

@rocky, I think this would be OK once mathics-ruby loads and works properly. By now, I would do the opposite: add a github-action test on mathics-ruby, and check against the branches of mathics-core that improve the required support.

Yes, that makes sense. But here we need #1176 to finish. This corrects some bugs in handling the "optional" operator in pattern matching. When you get a chance, please look that over since you know far more about Mathics3's pattern-matching code (and WMA) than I. Right now, these changes are pretty small.

@aravindh-krishnamoorthy
Copy link
Collaborator

Indeed, this sounds good once basic Rubi starts working...

@rocky rocky marked this pull request as ready for review December 19, 2024 23:39
@rocky
Copy link
Member Author

rocky commented Dec 19, 2024

Now that Rubi has merged, this is your last chance to weigh in before we merge this.

Of course, in order to use Rubi, you'll have to use a branch to make TimeConstrained work. @aravindh-krishnamoorthy started a discussion thread for longer-term solutions.

Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's try this. LGTM

@rocky rocky merged commit 3706cad into master Dec 20, 2024
14 checks passed
@rocky rocky deleted the Rubi-as-git-submodule branch December 20, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants