Add 3-arg Select and go over... #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 3-argument Select, by adding a parameter inside Structure's filter function.
Go over Structure class:
* remove duplication of filter() and add the count functionality needed
by Select[]
Update over Select doctests for 3 arg form. Move error checking to pytest where it belongs.
Also, broaden infinity tests on counts
This seems to be a result of recent work adding in unicode operators
This way we can deal with either unicode output of ASCII output. Also, start to split up monster test_strings.py unit test closer to the way the modules are written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3-argument Select, by adding a parameter inside Structure's filter function.
Go over Structure class:
Update over Select doctests for 3 arg form. Move error checking to pytest where it belongs.
Select[]count-parameter issue is mentioned in Mathics3/Mathics3-Rubi#2