Increased use of binary operator string values from JSON #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocky
force-pushed
the
increased-use-operator-strings-from-JSON
branch
from
1007725 to
d50a306
Compare
rocky
changed the title
|
This should stay in draft mode until Mathics3/mathics-scanner#111 is merged. Then, I'll revert the CI testing from the operator-refactor-part1.5 branch and we can merge this. Getting operator information in better shape is a prerequisite for the next release. |
rocky
changed the title
rocky
changed the title
|
Note: after this PR we may have a few more binary operators; also postfix and prefix operators should be done as well. However just this part is major disruption in of itself, to warrant stopping here and doing the others other PRs. |
|
Mathics-scanner code is merged, so we'll now try with master. If this works, I will merge. And maybe we can continue with prefix/postifx operators. |
Also add one more type annotation
rocky
force-pushed
the
increased-use-operator-strings-from-JSON
branch
from
4787770 to
a9b0d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick up binary operator string from enhanced Mathics-Scanner JSON operator tables.
For now, we have to limit to binary operators only.