Go MaxLengthIntStringConversion doc yet again... #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Merge this when you feel it is ready. |
rocky
force-pushed
the
MaxLengthIntStringConversion-redux
branch
from
aa42847 to
4cf4f39
Compare
The docstring has changed a bit. You still okay with this? |
|
It is OK, except for the two doctests that I marked, because have different results in Pyston and CPython |
Pyston 2.3.5 and CPython 3.11+ Thanks to mmatera for spotting this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstring text and examples gone over, yet again. It looks like we have a bug in Django in rendering
<and>in a string.