Tiny changes to tiny changes 2 #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocky
changed the base branch from
master
to
doc-code-another-round-of-tiny-changes-2
rocky
force-pushed
the
tiny-changes-to-tiny-changes-2
branch
2 times, most recently
from
b2dde03 to
46a2dc8
Compare
The `want_sorting` parameter was added when we had a bug in Mathics3 regarding not resetting decimal digits listing precision in a LRU caching.
Also perform some linting:
* remove unused import
* Reinstate "." at the end of a sentence
rocky
force-pushed
the
tiny-changes-to-tiny-changes-2
branch
from
46a2dc8 to
1cd7ae3
Compare
mmatera
reviewed
Feb 7, 2024
mathics/doc/common_doc.py
Outdated
| want_sorting = True | ||
| if want_sorting: | ||
| module_collection_fn = lambda x: sorted( | ||
| def module_collection_fn(_) -> list: |
There was a problem hiding this comment.
why does this function need to have an argument that in the end is not used?
There was a problem hiding this comment.
You are right.
This is a holdover from the stuff that came before where the "module" parameter was passed in but later it was taken from by the closure from a surrounding variable.
Is removed. now.
mmatera
reviewed
Feb 7, 2024
| @@ -608,21 +605,6 @@ def main(): | |||
| action="store_true", | |||
| help="print cache statistics", | |||
| ) | |||
| # FIXME: historically was weird interacting going on with | |||
mmatera
reviewed
Feb 7, 2024
rocky
force-pushed
the
tiny-changes-to-tiny-changes-2
branch
from
a66ab4e to
d79a6e1
Compare
rocky
merged commit 575fae4
into
doc-code-another-round-of-tiny-changes-2
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
want_sortingparameter. This was added when we had a bug in Mathics3 regarding not resetting decimal digits listing precision in a LRU caching.Also perform some linting: