Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precedence UpTee RoundImplies #101

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Precedence UpTee RoundImplies #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
86be7ff
fix #94
mmatera Nov 25, 2024
c251ee3
fixing the comment
mmatera Nov 25, 2024
c3a82cb
precedence tests using mathics
mmatera Nov 29, 2024
46a60c7
Merge remote-tracking branch 'origin/master' into precedence_tests
mmatera Nov 29, 2024
280a852
black
mmatera Nov 29, 2024
32e4c1a
fix typo
mmatera Nov 29, 2024
ed92736
fix precedences for UpTee and RoundImplies
mmatera Nov 30, 2024
980f479
add Precedence-Function for UpTee
mmatera Nov 30, 2024
4693362
fix typos in discussion. Extend it a little bit
mmatera Nov 30, 2024
aa90806
merge
mmatera Nov 30, 2024
fdadb1b
black
mmatera Nov 30, 2024
6b70b39
Merge branch 'master' into precedence_UpTee_RoundImplies
mmatera Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions mathics_scanner/data/operators.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@
# In[1] := WolframLanguageData["AddTo", "PrecedenceRanks"]
# Out[1]= {{expr1 +=expr2 , AddTo[expr1 ,expr2]} -> 73
#
# Note that 73 uses a diffrent precedence scheme than the one
# given by Precedence and used in Mathics3.
# Note that 73 is a number that belongs to a different precedence
# scheme than the one given by Precedence and used in Mathics3.
#
# Also Note that WolframLanguageData can also be used to give the
# ASCII and unicode character representations:
Expand Down Expand Up @@ -109,7 +109,7 @@
# "left-binary-operators", "right" will appar in JSON table under the key
# "right-binary-operators", "non-associative" under the key
# "non-associative-operators", "unknown" under the key "miscellaneous-operators",
# and None as "flat_binary_operators.
# and None as "flat_binary_operators".
#
# meaningful
# ---------
Expand Down Expand Up @@ -5553,7 +5553,7 @@ RightVectorBar:

RoundImplies:
Precedence-Function: 240
precedence: 200
precedence: 193
WolframLanguageData:
WolframLanguageData-corrected: 59
UnicodeCharacters.tr: 310
Expand Down Expand Up @@ -6919,7 +6919,8 @@ UpSetDelayed:
# comments:

UpTee:
precedence: 190
precedence: 197
Precedence-Function: 190
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An operational test demonstrates and ensures this, please?

WolframLanguageData: 60
WolframLanguageData-corrected: 60
UnicodeCharacters.tr: 390
Expand Down
2 changes: 1 addition & 1 deletion test/test_mathics_precedence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
# RoundImplies[a,UpTee[b,c]],
# But in Mathics as
# UpTee[RoundImplies[a, b], c]
# "RoundImplies", # WMA->240, Mathics->200, Must be ~193
"RoundImplies", # WMA->240, Mathics->200, Must be ~193
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why must it be ~193? Please write an isolated test that demonstrates this. Thanks.

"UpTee", # 190 Must be ~197
"Implies", # 200
"Equivalent",
Expand Down
Loading