Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving docstrings #105

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Improving docstrings #105

merged 4 commits into from
Dec 3, 2024

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Dec 3, 2024 •
edited
Loading

In this PR

  • a more detailed explanation of the goal of the tests and how was designed is included in the docstrings
  • The test for the numerical coincidence of Precedence against WMA was removed.
  • The name of the module constant that holds the ordered list of symbols was changed to a more Non-Yoda-English compatible form.

rocky
rocky reviewed Dec 3, 2024
View reviewed changes
test/test_mathics_precedence.py Outdated
@@ -1,5 +1,44 @@
"""
Test precedences
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Test precedences
Test operator precedences

@mmatera mmatera mentioned this pull request Dec 3, 2024
Merged
@rocky
Copy link
Member

rocky commented Dec 3, 2024

LGTM. Thanks.

@rocky rocky merged commit 306a798 into precedence_Undirected_and_Directed Dec 3, 2024
1 check passed
@rocky rocky deleted the remove_test_of_numerical_equality branch December 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocky rocky rocky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmatera @rocky