Correct FractionBox and other small changes #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocky
commented
Jan 5, 2025
| @@ -1940,7 +1940,7 @@ FractionBox: | |||
| WolframLanguageData-corrected: 31 | |||
| UnicodeCharacters.tr: | |||
| UnicodeCharacters-corrected.tr: 590 | |||
| operator: "\/" | |||
| operator: "\\/" | |||
There was a problem hiding this comment.
This is the important change.
rocky
commented
Jan 5, 2025
| @@ -378,7 +378,7 @@ def __eq__(self, other): | |||
| ) | |||
|
|
|||
| def __repr__(self): | |||
| return f"Token({self.tag}, {self.text}, {self.pos})" | |||
| return f"Token({repr(self.tag)}, {repr(self.text)}, {self.pos})" | |||
There was a problem hiding this comment.
This is a slightly nicer repr which makes clear which parts (tag and text) are strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FractionBox omission was noticed via the new box parsing work.
A slightly nicer repr() for Token - we make clear which parts (tag, text) are strings.
The other changes are more to complete a little more of the prior unfinished work.