Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box expr parsing #82

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Box expr parsing #82

wants to merge 9 commits into from

Conversation

rocky
Copy link
Member

@rocky rocky commented Oct 27, 2024

No description provided.

@rocky rocky requested a review from mmatera October 27, 2024 17:04
@rocky rocky marked this pull request as draft October 27, 2024 17:04
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rocky added 3 commits October 28, 2024 18:59
Add Filename test and more stringent boxing test

Correct type on feed message
@rocky rocky marked this pull request as ready for review October 29, 2024 17:47
@rocky
Copy link
Member Author

rocky commented Oct 29, 2024

@mmatera as before there is more to do, but this is now getting large.

TODO: more elaborate box testings including error scenarios.
Ad \( ... \) in CSV/yml examples fields which will be isolated in a PR

rocky added 2 commits October 29, 2024 13:54
although normally test standards are to use lowercase it makes sense here to follow capitalized token names in tests that test those kinds of tokens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants