Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkclean: Silence some bogus warnings #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkver
Copy link

@mkver mkver commented May 17, 2018

Currently mandatory elements like SeekPreRoll that are physically absent in the input file and only assumed because they are mandatory frequently lead to bogus warnings like "The SeekPreRoll element at -1 is not part of profile 'matroska v2', skipping".

PS: There is actually another issue here: If one remuxes a version two file, the same warning appears, although SeekPreRoll is only compatible with Matroska v4 and Webm. For Matroska v1-v3 one shouldn't assume SeekPreRoll at all.

Currently mandatory elements like SeekPreRoll that are actually absent in the input file and only assumed because they are mandatory frequently lead to bogus warnings like "The SeekPreRoll element at -1 is not part of profile 'matroska v2', skipping".
@robUx4
Copy link
Contributor

robUx4 commented Jun 3, 2018

If the EBML_MasterCheckContext() reports a bogus error then it should be fixed there (in libebml2). Also if the element is not part of Matroska v2 and in such a file then it's an issue in the file. It's normal to report that it's not going to be there (it may be bogus).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants